Skip to content

Heltec ESP32 Series boards update #9367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 18, 2024
Merged

Heltec ESP32 Series boards update #9367

merged 15 commits into from
Mar 18, 2024

Conversation

Heltec-Aaron-Lee
Copy link
Contributor

Description of Change

Fixes:

  • Fixes some basic information about previous development boards;
  • Fixes the option for LoRaWAN parameter in the Tools menu;
  • Remove useless parameter options;
  • Correcting typing issues.

Add:

  • Add Heltec new boards to the development framework;
  • Add external 32K Crystal oscillator option for LoRawWAN.

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Fix board definition format":
    • summary looks empty
    • type/action looks empty
  • the commit message "Heltec Capsule Sensor V3 information update":
    • summary looks empty
    • type/action looks empty
  • the commit message "Heltec E-Ink Driver board menu update":
    • summary looks empty
    • type/action looks empty
  • the commit message "Heltec E-Ink Driver board menu update":
    • summary looks empty
    • type/action looks empty
  • the commit message "Heltec ESP32 Series boards update":
    • summary looks empty
    • type/action looks empty
  • the commit message "Heltec Wireless Shell (V3) format update":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update Heltec boards defintion":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update Wireless Stick Lite V3 pin defintion":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update variants/heltec_capsule_sensor_v3/pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update variants/heltec_capsule_sensor_v3/pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update variants/heltec_ht_de01/pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update variants/heltec_wireless_mini_shell/pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update variants/heltec_wireless_mini_shell/pins_arduino.h":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️ Please consider squashing your 15 commits (simplifying branch history).
Messages
📖 This PR seems to be quite large (total lines of code: 2160), you might consider splitting it into smaller PRs

👋 Hello Heltec-Aaron-Lee, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 22c6386

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Heltec-Aaron-Lee PTAL on my comments.
Few point to be changed in almost all boards definition ( I did not cover everything in the review):

  • all build.board names must be uppercase
  • check formatting to make everything clear, remove or add empty lines please.

When fixed, ping me to review again.

@P-R-O-C-H-Y P-R-O-C-H-Y added Resolution: Awaiting response Waiting for response of author and removed Status: Review needed Issue or PR is awaiting review labels Mar 14, 2024
P-R-O-C-H-Y and others added 12 commits March 14, 2024 16:03
@P-R-O-C-H-Y
Merge branch 'master' into master
b728649
@Heltec-Aaron-Lee @P-R-O-C-H-Y
Update variants/heltec_capsule_sensor_v3/pins_arduino.h
ea2281d 
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
@Heltec-Aaron-Lee @P-R-O-C-H-Y
Update variants/heltec_capsule_sensor_v3/pins_arduino.h
3d8b586 
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
@Heltec-Aaron-Lee @P-R-O-C-H-Y
Update variants/heltec_ht_de01/pins_arduino.h
ce852cb 
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
@Heltec-Aaron-Lee @P-R-O-C-H-Y
Update variants/heltec_wireless_mini_shell/pins_arduino.h
7b1db53 
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
@Heltec-Aaron-Lee @P-R-O-C-H-Y
Update variants/heltec_wireless_mini_shell/pins_arduino.h
b49f56b 
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
@Heltec-Aaron-Lee
Fix board definition format
5761cfe
@Heltec-Aaron-Lee
Merge branch 'master' of https://github.com/Heltec-Aaron-Lee/arduino-…
911337d 
…esp32
@Heltec-Aaron-Lee
Update Wireless Stick Lite V3 pin defintion
27bb6f8
@Heltec-Aaron-Lee
Update Heltec boards defintion
3f59dac
@Heltec-Aaron-Lee
Heltec Wireless Shell (V3) format update
1de9574
@Heltec-Aaron-Lee
Heltec Capsule Sensor V3 information update
a6069a3
@Heltec-Aaron-Lee
Copy link
Contributor Author

@P-R-O-C-H-Y
Hi, thank you very much for taking the time to review. I have corrected the issues you mentioned, please review again.

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one fix needed :)
PTAL @Heltec-Aaron-Lee

@Heltec-Aaron-Lee
Copy link
Contributor Author

I apologize for my carelessness... I have corrected this issue, please review it again
@P-R-O-C-H-Y

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Mar 18, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request Mar 18, 2024
Merged
SuGlider added a commit to SuGlider/arduino-esp32 that referenced this pull request Mar 18, 2024
@SuGlider
heltec update from espressif#9367
f89d902
@me-no-dev me-no-dev merged commit ab322be into espressif:master Mar 18, 2024
55 checks passed
me-no-dev pushed a commit that referenced this pull request Mar 18, 2024
@SuGlider
backport: variants from 3.0.0 + fixes (#9381)
651a14c 
* feat: backport variants from 3.0.0

* heltec update from #9367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Heltec-Aaron-Lee @CLAassistant @P-R-O-C-H-Y @me-no-dev @VojtechBartoska